feat(sdk): Update the Goerli SCC contract address to the new value#3082
Merged
mergify[bot] merged 3 commits intodevelopfrom Jul 25, 2022
Merged
feat(sdk): Update the Goerli SCC contract address to the new value#3082mergify[bot] merged 3 commits intodevelopfrom
mergify[bot] merged 3 commits intodevelopfrom
Conversation
🦋 Changeset detectedLatest commit: 7b21c1d The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
This PR changes implementation code, but doesn't include a changeset. Did you forget to add one? |
|
Excited for this to get merged! As a developer who uses the SDK and is trying to migrate from Kovan to Goerli, having to wait hours to confirm messages sent from Goerli Optimism to Goerli is a large blocker. Hopefully this gets resolved and merged soon, and we can fully migrate to Goerli! |
Contributor
Author
|
You don't need to wait for it to be merged. As a workaround until the SDK
is updated, you can go to ***@***.***/sdk/dist/util` and edit
`contracts.js` to replace `0x72281826E90dD8A65Ab686fF254eb45Be426DD22` with
`0x9c945aC97Baf48cB784AbBB61399beB71aF7A378`.
Then you can follow the directions at
https://github.com/ethereum-optimism/optimism-tutorial/blob/2d1cafb02ce02cb396f65e9f66c66c81b3aaf878/cross-dom-comm/README.md
.
For an explanation of wait times, see
https://github.com/ethereum-optimism/community-hub/blob/f9343d0f06a77b62d3adc2c43a23ebf7930d6293/src/docs/developers/bridge/messaging.md#for-optimism-l2-to-ethereum-l1-transactions
…On Fri, Jul 22, 2022 at 5:50 PM chrismin ***@***.***> wrote:
Excited for this to get merged! As a developer who uses the SDK and is
trying to migrate from Kovan to Goerli, having to wait hours to confirm
messages sent from Goerli Optimism to Goerli is a large blocker. Hopefully
this gets resolved and merged soon, and we can fully migrate to Goerli!
—
Reply to this email directly, view it on GitHub
<#3082 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADBCGGIOMVJZHRKKVVBZZS3VVMQT5ANCNFSM54JORTVQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
smartcontracts
approved these changes
Jul 25, 2022
roninjin10
approved these changes
Jul 25, 2022
Contributor
|
This PR has been added to the merge queue, and will be merged soon. |
Contributor
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
1 similar comment
Contributor
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
maurelian
pushed a commit
that referenced
this pull request
Sep 15, 2022
…3082) * feat(sdk): Update the Goerli SCC contract address to the new value * feat(sdk): Bump the SDK version to 1.3.1 Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
sam-goldman
pushed a commit
that referenced
this pull request
Sep 15, 2022
…3082) * feat(sdk): Update the Goerli SCC contract address to the new value * feat(sdk): Bump the SDK version to 1.3.1 Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
nitaliano
pushed a commit
that referenced
this pull request
May 20, 2024
…3082) * feat(sdk): Update the Goerli SCC contract address to the new value * feat(sdk): Bump the SDK version to 1.3.1 Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This requires revving up the SDK, which I don't know how to do.